Skip to content

fix: validate tao ss58 checksums#312

Merged
anderdc merged 1 commit into
entrius:testfrom
volcano303:fix/tao-ss58-validation
May 20, 2026
Merged

fix: validate tao ss58 checksums#312
anderdc merged 1 commit into
entrius:testfrom
volcano303:fix/tao-ss58-validation

Conversation

@volcano303
Copy link
Copy Markdown
Contributor

@volcano303 volcano303 commented May 12, 2026

Summary

  • validate TAO addresses with Bittensor's SS58 checksum validator instead of regex-only shape checks
  • add regression coverage for checksum-mutated and base58-shaped invalid addresses

Issue

Closes #200

Validation

  • uv run ruff check allways/ neurons/ tests/test_scale.py
  • uv run pytest tests/test_scale.py::TestIsValidAddress -q
  • uv run pre-commit run --all-files
  • uv run pytest tests/

@xiao-xiao-mao xiao-xiao-mao Bot added the bug Something isn't working label May 12, 2026
@anderdc anderdc mentioned this pull request May 15, 2026
Closed
5 tasks
@anderdc anderdc merged commit 005d977 into entrius:test May 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anderdc anderdc anderdc approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TAO receive address not SS58-checksum-validated — user typo sends funds irrecoverably

2 participants

@volcano303 @anderdc